Prefer start module option to heuristics #45
Merged
+64
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
requested changes
Nov 1, 2025
Useful for defining a start module that doesn't have start/0 (but main/1). Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w44/start-module-precedence
branch
from
1ad714c to
bb6c95c
Compare
UncleGrumpy
requested changes
Nov 17, 2025
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
Thank you for the test. I feel much better now about future changes not breaking anything. I did catch one other small detail I overlooked during my first review.
UncleGrumpy
approved these changes
Nov 17, 2025
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
I was wrong about wanting a check there. After looking at atomvm/AtomVM#1984 and seeing that Gleam seems to prefer main/0, I think we should support that as an entry point in AtomVM and not do any checks here. There may be other start functions needed for other scenarios, so we should allow any module and not care about which functions are exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for defining a start module that doesn't have start/0 (but main/1).